[CARBONDATA-319] Bad Records logging for column data type is not proper#241
Closed
sujith71955 wants to merge 1 commit intoapache:masterfrom
Closed
[CARBONDATA-319] Bad Records logging for column data type is not proper#241sujith71955 wants to merge 1 commit intoapache:masterfrom
sujith71955 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
please find the pr builder result. |
gvramana
reviewed
Oct 17, 2016
|
|
||
| private void addEntryToBadRecords(Object[] r, int j, String columnName, | ||
| String dataType) { | ||
| if (DataType.LONG.toString().equals(dataType)) { |
Contributor
There was a problem hiding this comment.
This check is not required.
sujith71955
force-pushed
the
master_BadRecord_Issue
branch
2 times, most recently
from
d71eaae to
425e3c0
Compare
Bad Records logging for column data type is not proper in case of long, carbon system while creating the table metadata uses BIGINT instead of LONG , internally it converts the bigint to long type and processes , while processing the data if any long type data is having issue it will be logged into the bad record with data type Long which is not proper since as per the metadata the datatype of column is BIGINT.
Contributor
Author
|
Comments handled, Please find the PR Build status. |
Contributor
|
LGTM |
Beyyes
pushed a commit
to Beyyes/carbondata
that referenced
this pull request
Jul 12, 2018
Change the threshold of image gc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Bad Records logging for column data type is not proper in case of long, carbon system while creating the table metadata uses BIGINT instead of LONG , internally it converts the bigint to long type and processes , while processing the data if any long type data is having issue it will be logged into the bad record with data type Long which is not proper since as per the metadata the datatype of column is BIGINT.
Solution :
Pass name for each data type ENUM constant in constructor, while logging the bad record get the column data type name value from the data type ENUM constant, for LONG the name will be BIGINT.