Skip to content

feat: exprtk evalutor support RBAC model and test#187

Merged
EmperorYP7 merged 3 commits into
apache:masterfrom
sheny1xuan:exprtk_moretest
Feb 26, 2022
Merged

feat: exprtk evalutor support RBAC model and test#187
EmperorYP7 merged 3 commits into
apache:masterfrom
sheny1xuan:exprtk_moretest

Conversation

@sheny1xuan
Copy link
Copy Markdown
Contributor

stonex added 2 commits February 24, 2022 15:46
Signed-off-by: stonex <1479765922@qq.com>
Signed-off-by: stonex <1479765922@qq.com>
@casbin-bot
Copy link
Copy Markdown

@EmperorYP7 @divy9881 @noob20000405 please review

@hsluoyz
Copy link
Copy Markdown
Member

hsluoyz commented Feb 25, 2022

@EmperorYP7

Copy link
Copy Markdown
Contributor

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

typedef typename generic_type::vector_view vector_t;
typedef typename generic_type::string_view string_t;

typedef typename exprtk::igeneric_function<T>::parameter_list_t
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@EmperorYP7 EmperorYP7 merged commit 1fba9ea into apache:master Feb 26, 2022
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.48.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants