feat: exprtk evaluator support RBAC with domain#188
Merged
Conversation
Contributor
sheny1xuan
commented
Feb 26, 2022
sheny1xuan
commented
- Exprtk evaluator support RBAC with domain.
- Use ExprtkFunctionFactory to generate different type exprtk function.
Signed-off-by: stonex <1479765922@qq.com>
|
@EmperorYP7 @divy9881 @noob20000405 please review |
Member
|
@sheny1xuan plz remember updating this table: https://casbin.org/docs/en/syntax-for-models#expression-evaluator |
Member
|
@EmperorYP7 plz review |
EmperorYP7
approved these changes
Mar 13, 2022
Contributor
EmperorYP7
left a comment
EmperorYP7
left a comment
There was a problem hiding this comment.
LGTM!
Apologies for the delayed review.
|
🎉 This PR is included in version 1.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.