feat: fix build warnings for all targets#236
Merged
Merged
Conversation
|
@sheny1xuan @cs1137195420 please review |
Member
|
@EmperorYP7 plz fix:
|
fix: CMake import issues fix: virtual destructor warning chore: removed auto generated files
EmperorYP7
force-pushed
the
fix/warnings
branch
from
6ccc262 to
a597e54
Compare
hsluoyz
changed the title
|
🎉 This PR is included in version 1.54.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235
Description
This PR fixes all the warnings and gives a clean console on building all the targets.
Screenshots/Testimonials