Skip to content

fix: set_target_properties's VERSION#237

Merged
EmperorYP7 merged 1 commit into
apache:masterfrom
ba7lya:master
Sep 11, 2023
Merged

fix: set_target_properties's VERSION#237
EmperorYP7 merged 1 commit into
apache:masterfrom
ba7lya:master

Conversation

@ba7lya
Copy link
Copy Markdown
Contributor

@ba7lya ba7lya commented Sep 11, 2023

Fixes

#205

Description

In "./casbin/CMakeLists.txt", line 79~82,

set_target_properties(casbin PROPERTIES 
    PREFIX ""
    VERSION ${CMAKE_PROJECT_VERSION}
)

well, if i integrate casbin-cpp to my project as a thirdparty via cmake, the VERSION property will refer to my top project's VERSION property, cause CMAKE_PROJECT_VERSION means that, so it's unreasonable.

Instead, by

set_target_properties(casbin PROPERTIES 
    PREFIX ""
    VERSION ${PROJECT_VERSION}
)

the VERSION property will refer to casbin-cpp's top project's VERSION property, i think that's what we want.

@casbin-bot
Copy link
Copy Markdown

@EmperorYP7 @sheny1xuan @cs1137195420 please review

Copy link
Copy Markdown
Contributor

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run this command to resolve the semantic PR CI error:

git commit --amend -m "fix: set_target_properties's VERSION"

@ba7lya
Copy link
Copy Markdown
Contributor Author

ba7lya commented Sep 11, 2023

Run this command to resolve the semantic PR CI error:

git commit --amend -m "fix: set_target_properties's VERSION"

Thanks for the tip :)

Copy link
Copy Markdown
Contributor

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ba7lya

@EmperorYP7 EmperorYP7 merged commit 242f616 into apache:master Sep 11, 2023
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.54.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants