fix: Stop including README as top-level data file in package#296
Merged
Conversation
|
@Nekotoxin please review |
|
|
huonw
changed the title
|
🎉 This PR is included in version 1.18.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Chimou0
pushed a commit
to Chimou0/pycasbin
that referenced
this pull request
Jul 17, 2025
Chimou0
pushed a commit
to Chimou0/pycasbin
that referenced
this pull request
Jul 17, 2025
## [1.18.3](apache/casbin-pycasbin@v1.18.2...v1.18.3) (2023-05-22) ### Bug Fixes * Exclude tests from package ([apache#297](apache#297)) ([9b014a2](apache@9b014a2)) * Stop including README as top-level data file in package ([apache#296](apache#296)) ([e85e9b9](apache@e85e9b9))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #295
Including the
README.mdas a top-level data file is unconventional and can interfere with other packages if they also accidentally include theirREADME.md: installing both packages leads to the second one overwriting theREADME.mdof the first one. (A lot of the casbin python packages interfere with each other like this.)The contents of the README is available as the package's long description, which is included in its
METADATAfile.In addition to that problem, running
python setup.py bdist_wheelresults in a warning, tangentially referencing this problem:This fixes (partially) #295, for this repository.