feat: enhance performance by checking before allocation in default role manager#398
Merged
hsluoyz merged 1 commit intoapache:masterfrom Nov 4, 2025
H-Chris233:enhance/improve_performance
Merged
feat: enhance performance by checking before allocation in default role manager#398hsluoyz merged 1 commit intoapache:masterfrom H-Chris233:enhance/improve_performance
hsluoyz merged 1 commit intoapache:masterfrom
H-Chris233:enhance/improve_performance
Conversation
|
|
Benchmark for 2bf5287Click to view benchmark
|
hsluoyz
changed the title
hsluoyz
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
=========================================
- Coverage 65.54% 0 -65.55%
=========================================
Files 25 0 -25
Lines 1956 0 -1956
=========================================
- Hits 1282 0 -1282
+ Misses 674 0 -674 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
# [2.16.0](v2.15.0...v2.16.0) (2025-11-04) ### Features * enhance performance by checking before allocation in default role manager ([#398](#398)) ([b27b9d1](b27b9d1))
|
🎉 This PR is included in version 2.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #263
In default_role_manager.rs
function:affected_domain_names
By reducing memory allocation once and checking before allocationTo improve performance.