feat: return clear error for invalid JSON when EnableAcceptJsonRequest is enabled#1610
Merged
feat: return clear error for invalid JSON when EnableAcceptJsonRequest is enabled#1610
Conversation
|
|
When EnableAcceptJsonRequest is enabled, strings that look like JSON (starting with { or [) are now parsed. If parsing fails, a clear error is returned instead of silently ignoring the error and causing confusing "is not a struct or map" errors later.
Changes:
- Only attempt JSON parsing for strings starting with { or [
- Return descriptive error when JSON parsing fails
- Add test case for invalid JSON handling
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix JSON string arguments parsing in Enforce
Return clear error for invalid JSON when EnableAcceptJsonRequest is enabled
Dec 19, 2025
hsluoyz
added a commit
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
EnableAcceptJsonRequest(true)is enabled, invalid JSON strings (e.g., containing\xescape sequences not supported by JSON spec) fail to parse but errors are silently ignored. The string remains unparsed, causing confusing downstream errors like "Unable to access 'Name', 'r_sub' is not a struct or map" when matchers attempt field access.Changes
enforcer.go{or["failed to parse JSON parameter at index %d: %w"enforcer_json_test.go(new)Example
Before:
After:
Note: JSON only supports
\",\\,\/,\b,\f,\n,\r,\t, and\uXXXXescape sequences.\xis not valid JSON.Original prompt
EnableAcceptJsonRequest(true)#1605💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.