Add missing Accord debug vtables, fix exisiting ones#135
Merged
iamaleksey merged 1 commit intoapache:trunkfrom Nov 11, 2024
Merged
Add missing Accord debug vtables, fix exisiting ones#135iamaleksey merged 1 commit intoapache:trunkfrom
iamaleksey merged 1 commit intoapache:trunkfrom
Conversation
dcapwell
approved these changes
Nov 8, 2024
Contributor
dcapwell
left a comment
dcapwell
left a comment
There was a problem hiding this comment.
Mostly LGTM. When it comes to progress log im very ignorant on the rewrite so not sure if what is exposed makes as much sense, will leave that to Benedict if he wants to review
patch by Aleksey Yeschenko; reviewed by Benedict Elliott Smith for CASSANDRA-20062
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch by Aleksey Yeschenko; reviewed by Benedict Elliott Smith for CASSANDRA-20062