Merged
Conversation
dcapwell
reviewed
Nov 13, 2024
| case ASYNC: | ||
| case INCR: | ||
| case SYNC: | ||
| return this.compareTo(ifSyncRequireAtLeast) >= 0; |
Contributor
There was a problem hiding this comment.
so for satisfies (only method used in this PR) this is only true for SYNC and RECOVER? ASYNC, INCR, and SYNC are all new to me, so need to catch up on the recent changes to better understand this change.
Contributor
Author
There was a problem hiding this comment.
yes, ASYNC and INCR basically don't guarantee they have fetched what was requested. They'll accept partial information. That said, this isn't implemented on the load side yet so today it's only declarative of intent/requirements on the task side.
…ctions should witness only precisely intersecting txns))
belliottsmith
force-pushed
the
key-recovery-sees-ranges
branch
from
a6d9686 to
c331b23
Compare
…ctions should witness only precisely intersecting txns))
dcapwell
approved these changes
Nov 18, 2024
Contributor
dcapwell
left a comment
dcapwell
left a comment
There was a problem hiding this comment.
Accord side LGTM, trying to wrap up the C* now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C* side: apache/cassandra#3679