CASSANALYTICS-120: Quote identifiers option must be set to true if ttl has mixed case column name#172
Open
sarankk wants to merge 2 commits intoapache:trunkfrom
Open
CASSANALYTICS-120: Quote identifiers option must be set to true if ttl has mixed case column name#172sarankk wants to merge 2 commits intoapache:trunkfrom
sarankk wants to merge 2 commits intoapache:trunkfrom
Conversation
…l has mixed case column name
sarankk
force-pushed
the
CASSANALYTICS-120
branch
from
67a8ff9 to
bf797b2
Compare
Contributor
Author
|
Thanks @frankgh for the review, good spot. Addressed your comment. Instead of automatically setting quote identifiers option to true, added a validation instead to throw if users use mixed case column names without quote identifiers. With current behavior, when perRow TTL option is set with mixed case TTL column name and without quote identifiers, the job succeeds but silently rewrites existing TTLs of the rows to null. Hence throwing to fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users set TTL column name or timestamp column name to be mixed case, they have to set quote identifiers option to true for Cassandra to resolve the column name correctly. Sometimes users miss setting quote identifiers option and perRowTTL setting incorrectly overrides their existing TTL with null values when bulk write job runs. This patch fixes this, by checking for mixed case column names and setting quote identifiers option when required.