Skip to content

Conversation

@michaelsembwever
Copy link
Member

From the dtest build scripts remove the "--no-site-packages" flag (which breaks virtualenv >20), and add a tmpdir environment variable (pointing to a tmp folder in current directory)

Copy link

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelsembwever
Copy link
Member Author

michaelsembwever commented Apr 8, 2020

I shall test it on a local jenkins and then merge…

@michaelsembwever
Copy link
Member Author

Tested with local jenkins.

Testing requires the EnvInject plugin so to override (bind) the variables in https://github.com/apache/cassandra-builds/blob/master/jenkins-dsl/cassandra_job_dsl_seed.groovy

The CASSANDRA_BUILDS_GIT_URL and CASSANDRA_BUILDS_BRANCH variables have to be overridden so the dsl generated jobs can checkout this PR and build with it.
eg

CASSANDRA_GIT_URL="https://github.com/thelastpickle/cassandra-builds.git"
CASSANDRA_BUILDS_BRANCH="mck/build-scripts--remove-no-site-packages-flag--add-tmpdir"

This is done under Jenkins > Cassandra-Job-DSL > Configure Job > General > Prepare an environment for the run
Screenshot 2020-04-08 at 10 19 15

@michaelsembwever michaelsembwever force-pushed the mck/build-scripts--remove-no-site-packages-flag--add-tmpdir branch from 65d2612 to b2bd5a3 Compare April 8, 2020 08:30
@michaelsembwever
Copy link
Member Author

michaelsembwever commented Apr 8, 2020

tmp directory had to be first created, and cleaned later. have added it to the patch.

@michaelsembwever michaelsembwever force-pushed the mck/build-scripts--remove-no-site-packages-flag--add-tmpdir branch 3 times, most recently from ba8b214 to 43efea2 Compare April 8, 2020 09:43
…ich breaks virtualenv >20), and add a tmpdir environment variable (pointing to a `tmp` folder in current directory)
@michaelsembwever michaelsembwever force-pushed the mck/build-scripts--remove-no-site-packages-flag--add-tmpdir branch from 43efea2 to 33ba1e3 Compare April 8, 2020 10:01
@michaelsembwever michaelsembwever merged commit 33ba1e3 into apache:master Apr 8, 2020
@michaelsembwever michaelsembwever deleted the mck/build-scripts--remove-no-site-packages-flag--add-tmpdir branch January 4, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants