Skip to content

Conversation

@azotcsit
Copy link
Contributor

@azotcsit azotcsit commented Feb 2, 2022

It would be nice to see what exact versions of tools are used for the build process. Related to the query in https://issues.apache.org/jira/browse/INFRA-22823.

[ -d "${cassandra_builds_dir}" ] || { echo >&2 "cassandra-builds directory must exist"; exit 1; }

# print debug information on versions
ant -version
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are outputs from my local:

Apache Ant(TM) version 1.10.11 compiled on July 10 2021
pip 20.3.3 from /usr/local/lib/python3.8/dist-packages/pip (python 3.8)
virtualenv 20.0.17 from /usr/lib/python3/dist-packages/virtualenv/__init__.py
Docker version 20.10.11, build dea9396e18

command -v git >/dev/null 2>&1 || { echo >&2 "git needs to be installed"; exit 1; }
[ -f "build.xml" ] || { echo >&2 "build.xml must exist"; exit 1; }

# print debug information on versions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are outputs from my local:

Apache Ant(TM) version 1.10.11 compiled on July 10 2021
git version 2.25.1

@michaelsembwever
Copy link
Member

michaelsembwever commented Feb 2, 2022

nice!

can we also please add

pip --version
virtualenv --version

into cassandra-dtest-pytest.sh

and

docker --version

into cassandra-dtest-pytest-docker.sh and cassandra-test-docker.sh

@azotcsit azotcsit force-pushed the cassandra-16630_junit5 branch from e860596 to f140a6e Compare February 2, 2022 21:09
@azotcsit
Copy link
Contributor Author

azotcsit commented Feb 2, 2022

pip --version
virtualenv --version

Added pip3 (pip3 command is called instead pip), virtualenv and ant (it is also called).

docker --version

Added to "start the docker container" part of the condition.

patch by Aleksei Zotov; reviewed by Mick Semb Wever for CASSANDRA-16630
@azotcsit azotcsit force-pushed the cassandra-16630_junit5 branch from f140a6e to 8475f6b Compare February 2, 2022 21:14
@azotcsit
Copy link
Contributor Author

azotcsit commented Feb 2, 2022

@michaelsembwever is there a way to trigger Jenkins build against this branch? Even though the changes seem to be trivial and safe, it would be nice to ensure they break nothing.

@michaelsembwever
Copy link
Member

@michaelsembwever is there a way to trigger Jenkins build against this branch? Even though the changes seem to be trivial and safe, it would be nice to ensure they break nothing.

unfortunately no. this stuff gets tested against a local jenkins installation. (or cloning jobs, and manually adjusting their configuration to use this branch of cassandra-builds, under the patches tab).

(ideally i dream about using the jenkins operator to be able to write a script that fires a full ci-cassandra.a.o clone up in a k8s cluster…)

@azotcsit azotcsit merged commit 51a654f into apache:trunk Feb 5, 2022
@azotcsit azotcsit deleted the cassandra-16630_junit5 branch February 5, 2022 12:50
@azotcsit
Copy link
Contributor Author

azotcsit commented Feb 5, 2022

The changes seem to be working fine, you can check https://ci-cassandra.apache.org/view/Cassandra%204.1/job/Cassandra-trunk/935/ build for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants