CPP-212 - WIP expose SASL authentication (Do not merge!) #144
Conversation
There was a problem hiding this comment.
single thread access: this seems to be contradicted by the Multithread comment in main() below. https://github.com/datastax/cpp-driver/pull/144/files#diff-8fa0bb629c64393413a846a276378027R102
There was a problem hiding this comment.
Hmmm. The the data argument is different from auth->data. I need to figure out how to make that not confusing....
There was a problem hiding this comment.
You reminded me of another comment I forgot to mention: Is CassAuth.data ever used for anything, or is it always SaslAuthenticator.data_?
|
This looks really good. |
|
Hi Michael, it's great to see you guys have this working in progress. I'm just wondering what the status of this right now? Do you guys have any plan when to push it out? I need this and am really waiting on it. Appreciate it! - Yinping |
|
@yippeeH This feature is code complete (minus a couple code review changes) and it needs to be formally tested. We haven't released this feature because there wasn't any demand for it and we didn't have an integrator to give us feedback about the API. What type of authentication system are you planning to integrate with the SASL API? Kerberos? If I merge this on to the latest would you be able to test your integration from an unofficial release and provide feedback? |
|
We are using a custom authentication implementation that is not a defined SASL mechanism, but requires a custom initial response callback from the driver. We would definitely be willing to test from an unofficial release and provide feedback. |
|
I'm moving this work to another branch and will reopen a new PR. I will reference this. |
3 participants
No description provided.