Resolve multiple addresses for each domain name.#282
Merged
mpenick merged 2 commits intoapache:masterfrom Jun 28, 2016
mkm85:resolve_multiple_ips
Merged
Resolve multiple addresses for each domain name.#282mpenick merged 2 commits intoapache:masterfrom mkm85:resolve_multiple_ips
mpenick merged 2 commits intoapache:masterfrom
mkm85:resolve_multiple_ips
Conversation
…o the list of hosts to try
|
Hi @mkm85, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
|
Thank you @mkm85 for signing the Contribution License Agreement. Cheers, |
Contributor
|
Thanks for the pull request. I've create a JIRA issue to track it: https://datastax-oss.atlassian.net/browse/CPP-364. I'll pull this into master right after 2.4 releases. |
| bool is_timed_out() { return status_ == FAILED_TIMED_OUT; } | ||
| Status status() { return status_; } | ||
| const Address& address() const { return address_; } | ||
| const std::vector<Address>& addresses() const { return addresses_; } |
Contributor
There was a problem hiding this comment.
There's an AddressVec typedef in address.h. I'd prefer this use that.
mikefero
pushed a commit
that referenced
this pull request
Sep 4, 2019
* Add example for cloud (CaaS) * Fix crash when the socket times out during connection * Handle `SSL_ERROR_ZERO_RETURN` properly * Initialize the SSL library when using cloud * Fix cloud `local_dc` issue where `ControlConnection::local_dc()` is used, but is never set * Remove authentication using cloud secure connect bundle * Remove secure bundle authentication from unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve multiple addresses for each domain name. Before only one IP was returned even if the domain name resolves to several IP addresses. This is useful if a domain name resolves to all the the client seednodes.
The code is tested but no test is included since it would rely on a nameserver which cannot be simply and reliably provided to an integration test.