Conversation
|
|
||
| uint64_t Handler::request_timeout_ms(const Config& config) const { | ||
| uint64_t request_timeout_ms = request_->request_timeout_ms(); | ||
| if (request_timeout_ms == CASS_UINT64_MAX) { |
Contributor
There was a problem hiding this comment.
0 might be better than CASS_UINT64_MAX to set assign the default cluster configuration timeout.
uv_start_timer indicates:
If timeout is zero, the callback fires on the next event loop iteration. If repeat is non-zero, the callback fires first after timeout milliseconds and then repeatedly after repeat milliseconds.
Reason being is a user might want to set the max timeout in order to "wait forever" and might by default set that value to the max.
Contributor
|
Besides the one comment; 👍 |
added 2 commits
June 13, 2016 09:13
0 means no timeout and CASS_UINT64_MAX means use the cluster-level request timeout (default). Added header documentation to clarify.
mikefero
added a commit
that referenced
this pull request
Oct 25, 2019
CPP-818 - Add configuration properties to Insights startup message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.