CPP-747 Fix case sensitive keyspaces #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenick
commented
Feb 14, 2020
|
|
||
| private: | ||
| size_t index_mask_; | ||
| size_t count_; |
Contributor
Author
There was a problem hiding this comment.
Unused variable. Unrelated.
mpenick
commented
Feb 14, 2020
| return true; | ||
| } | ||
|
|
||
| bool is_valid_lower_cql_id(const String& str) { |
Contributor
Author
There was a problem hiding this comment.
This was implemented incorrectly.
mpenick
commented
Feb 14, 2020
|
|
||
| String& escape_id(String& str) { return is_valid_lower_cql_id(str) ? str : quote_id(str); } | ||
|
|
||
| String& to_cql_id(String& str) { |
Contributor
Author
There was a problem hiding this comment.
to_cql_id() was dead code.
mikefero
approved these changes
Feb 14, 2020
Comment on lines
+29
to
+33
| virtual std::string default_keyspace() { | ||
| std::string temp(Integration::default_keyspace()); | ||
| temp[0] = std::toupper(temp[0]); | ||
| return "\"" + temp + "\""; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.