Skip to content

Various integration test fixes #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
absurdfarce merged 2 commits into from
Nov 17, 2021
Merged

Various integration test fixes #520

absurdfarce merged 2 commits into from
Nov 17, 2021

Conversation

@absurdfarce
Copy link
Contributor

@absurdfarce absurdfarce commented Nov 12, 2021

No description provided.

absurdfarce
absurdfarce commented Nov 12, 2021
View reviewed changes
tests/src/integration/tests/test_auth.cpp

// Iterate over all known/supported protocol versions
logger_.add_critera("Key may not be empty");
logger_.add_critera("Password must not be null");
Copy link
Contributor Author

@absurdfarce absurdfarce Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to match the message observed for the default C* version (3.11.6)

Copy link
Contributor

@mpenick mpenick Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave the old criteria and add the new one? Then update the logger count check to a > 0? I don't know why this asserts a specific count...

Copy link
Contributor Author

@absurdfarce absurdfarce Nov 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like that quite a bit better than my initial change. I'll update.

absurdfarce
absurdfarce commented Nov 12, 2021
View reviewed changes
tests/src/integration/tests/test_auth.cpp
*/
Session session = connect_using_credentials(i, "", "");
ASSERT_EQ(session.connect_error_code(), CASS_ERROR_LIB_NO_HOSTS_AVAILABLE);
ASSERT_EQ(session.connect_error_code(), CASS_ERROR_SERVER_BAD_CREDENTIALS);
Copy link
Contributor Author

@absurdfarce absurdfarce Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was reporting this error rather than "no hosts available" and it seems more descriptive anyway

absurdfarce
absurdfarce commented Nov 12, 2021
View reviewed changes
tests/src/integration/tests/test_auth.cpp

// Iterate over all known/supported protocol versions
logger_.add_critera("Key may not be empty");
logger_.add_critera("Authentication ID must not be null");
Copy link
Contributor Author

@absurdfarce absurdfarce Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, update to match what's going on with 3.11.6

absurdfarce
absurdfarce commented Nov 12, 2021
View reviewed changes
tests/src/integration/tests/test_auth.cpp

// Iterate over all known/supported protocol versions
logger_.add_critera("and/or password are incorrect");
logger_.add_critera("Password must not be null");
Copy link
Contributor Author

@absurdfarce absurdfarce Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, update to match what's going on with 3.11.6

absurdfarce
absurdfarce commented Nov 12, 2021
View reviewed changes
tests/src/integration/tests/test_auth.cpp
*/
Session session = connect_using_credentials(i, NULL, "pass");
ASSERT_EQ(session.connect_error_code(), CASS_ERROR_LIB_NO_HOSTS_AVAILABLE);
ASSERT_EQ(session.connect_error_code(), CASS_ERROR_SERVER_BAD_CREDENTIALS);
Copy link
Contributor Author

@absurdfarce absurdfarce Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, "bad credentials" seems more correct here

mpenick
mpenick approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@mpenick mpenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@mpenick
Copy link
Contributor

mpenick commented Nov 16, 2021

Look good locally:

[==========] Running 6 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 6 tests from AuthenticationTests
[ RUN      ] AuthenticationTests.Integration_Cassandra_ProtocolVersions
[       OK ] AuthenticationTests.Integration_Cassandra_ProtocolVersions (9427 ms)
[ RUN      ] AuthenticationTests.Integration_Cassandra_InvalidEmptyCredentials
[       OK ] AuthenticationTests.Integration_Cassandra_InvalidEmptyCredentials (2054 ms)
[ RUN      ] AuthenticationTests.Integration_Cassandra_InvalidNullUsernameCredentials
[       OK ] AuthenticationTests.Integration_Cassandra_InvalidNullUsernameCredentials (2392 ms)
[ RUN      ] AuthenticationTests.Integration_Cassandra_InvalidNullPasswordCredentials
[       OK ] AuthenticationTests.Integration_Cassandra_InvalidNullPasswordCredentials (3305 ms)
[ RUN      ] AuthenticationTests.Integration_Cassandra_BadCredentials
[       OK ] AuthenticationTests.Integration_Cassandra_BadCredentials (3663 ms)
[ RUN      ] AuthenticationTests.Integration_Cassandra_AuthenticatorSetErrorNull
[       OK ] AuthenticationTests.Integration_Cassandra_AuthenticatorSetErrorNull (4112 ms)
[----------] 6 tests from AuthenticationTests (24953 ms total)

[----------] Global test environment tear-down
[==========] 6 tests from 1 test case ran. (24953 ms total)
[  PASSED  ] 6 tests.

@absurdfarce absurdfarce merged commit c7472bf into master Nov 17, 2021
fsaporito pushed a commit to cloudian/cpp-driver that referenced this pull request May 9, 2023
@absurdfarce @fsaporito
Various integration test fixes (apache#520)
67eb00f 
Fix for AuthenticationTests against default C* version (3.11.6)
@absurdfarce absurdfarce deleted the integration_test_fixes branch October 29, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mpenick mpenick mpenick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@absurdfarce @mpenick