Add no-read assert to read-repair test#39
Closed
ifesdjeen wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
aweisberg
reviewed
Oct 8, 2018
read_repair_test.py
Outdated
| assert storage_proxy.speculated_rr_read == 0 | ||
| assert storage_proxy.speculated_rr_write == 0 | ||
|
|
||
| warn = node2.grep_log("Message-to-self TYPE:READ") |
Contributor
There was a problem hiding this comment.
Is this something we want to check for in all dtests all the time as part of checking the log for errors?
It might help us avoid leaving spammy log lines that don't mean much to users in the long run.
Contributor
Author
There was a problem hiding this comment.
Ultimately - yes. But unfortunately there are still a couple of places we still do that. Maybe we should widen the scope of the ticket and check more places where this is happening. Or open a separate issue.
ifesdjeen
force-pushed
the
avoid-querying-self-through-ms
branch
from
ed1055e to
efb3a1a
Compare
Contributor
Author
|
Thank you for the review, committed the latest version manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.