Skip to content

small optimization - lookup enum value only once #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adutra merged 1 commit into from
Nov 21, 2018
Merged

small optimization - lookup enum value only once #1133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions driver-mapping/src/main/java/com/datastax/driver/mapping/Mapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,9 @@ private ListenableFuture<BoundStatement> saveQueryAsync(
T entity, final EnumMap<Option.Type, Option> options) {
final Map<AliasedMappedProperty, Object> columnToValue =
new TreeMap<AliasedMappedProperty, Object>();
final boolean useUnsetForNullValue =
!shouldSaveNullFields(options) && manager.protocolVersionAsInt >= 4;
final boolean includeColumnsWithNullValue =
shouldSaveNullFields(options) || useUnsetForNullValue;
final boolean shouldSaveNullFields = shouldSaveNullFields(options);
final boolean useUnsetForNullValue = !shouldSaveNullFields && manager.protocolVersionAsInt >= 4;
final boolean includeColumnsWithNullValue = shouldSaveNullFields || useUnsetForNullValue;

for (AliasedMappedProperty col : mapper.allColumns) {
Object value = col.mappedProperty.getValue(entity);
Expand Down