Conversation
Motivation: Users of the binary tarball noticed that the netty-common dependency was missing, via a NoClassDefFoundError for io.netty.util.Timer. This was caused by netty-common being excluded as it is a transitive dependency of netty-transport-epoll. While it is also a transitive dependency of included jars, the maven-assembly-plugin still excludes it. Modifications: Remove the use of useTransitiveFiltering in the dependencySet. This is ok as netty-transport-epoll dependencies are depended on by the driver jar already. Result: netty-common jar is now included in the lib directory of the binary tarball.
adutra
approved these changes
Jan 3, 2019
Contributor
adutra
left a comment
adutra
left a comment
There was a problem hiding this comment.
I created a small project using the binary tarball and validated that the project works and a session can be created. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Users of the binary tarball noticed that the netty-common dependency was
missing, via a NoClassDefFoundError for io.netty.util.Timer.
This was caused by netty-common being excluded as it is a transitive
dependency of netty-transport-epoll. While it is also a transitive
dependency of included jars, the maven-assembly-plugin still excludes
it.
Modifications:
Remove the use of useTransitiveFiltering in the dependencySet. This is
ok as netty-transport-epoll dependencies are depended on by the driver jar
already.
Result:
netty-common jar is now included in the lib directory of the binary
tarball.
This took quite a bit of investigation, but I think this is the best solution available. The alternative would be to list
netty-commonas an explicit dependency ofdriver-core. RemovinguseTransitiveFilteringfor core does the trick, and shouldn't be an issue as long asnetty-transport-epolldoes not add a platform specific dependency which seems very unlikely.