Changelog updates to reflect work that went out in 4.18.0 #1914
Conversation
|
|
||
| ### 4.18.0 | ||
|
|
||
| - [improvement] PR 1689: Add support for publishing percentile time series for the histogram metrics (nparaddi-walmart) |
There was a problem hiding this comment.
Historically we've only included JAVA tickets in the changelog but this will obviously be changing as we transition to CASSANDRA tickets for the Java driver. Rather than creating JAVA tickets for a few user-contributed changes (such as this one) it seemed easier to just include an explicit reference to the PR.
There was a problem hiding this comment.
I like including the CASSANDRA jira if there is one, I think the particular cases where there is no jira, referencing the PR is good (which I think was both of these) 👍
At some point will be push for all contributions to be tied to a jira ticket?
There was a problem hiding this comment.
Yeah, both of the commits in question for this change came in as contributions from the community and weren't tied to any existing ticket (either JAVA or CASSANDRA).
Honestly I'm kind of in two minds about the idea of connecting everything to a CASSANDRA ticket @tolbertam. We tried to do something like that for a while on the Java side and I'm not sure there's a huge benefit. The PR gives you an identifier/address/URL you can use to refer to the change and any discussion can happen on the PR itself... in a lot of ways it's similar to having a JIRA ticket.
I don't have super-strong feelings on the matter so I'm open to pursuing a policy of tying any change to a CASSANDRA ticket... but it's not immediately clear to me it offers the benefits it appears to.
| - [improvement] PR 1617: Improve ByteBufPrimitiveCodec readBytes (chibenwa) | ||
| - [improvement] JAVA-3095: Fix CREATE keyword in vector search example in upgrade guide | ||
| - [improvement] JAVA-3100: Update jackson-databind to 2.13.4.1 and jackson-jaxrs-json-provider to 2.13.4 to address recent CVEs | ||
| - [improvement] JAVA-3089: Forbid wildcard imports |
There was a problem hiding this comment.
Normally build and test fixes aren't included in the changelog but I made an exception for this one; it could have developer-facing impacts. The docs have always suggested to avoid wildcard imports but actually mandating them in the Maven build is a new thing.
|
Can't add my +1 for some reason but I approve this message as well. :) |
Patch by Bret McGuire; reviewed by Bret McGuire, Alexandre Dutra for PR 1914
absurdfarce
force-pushed
the
4180_changelog
branch
from
91778ce to
7a86270
Compare
4 participants
When 4.18.0 was released we had a number of fixes already in the 4.x branch that hadn't been released with the last DataStax release (4.17.0). This PR updates the changelog to correctly indicate the various fixes that were included in this release.