CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver#1960
Closed
SiyaoIsHiding wants to merge 13 commits intoapache:3.xfrom
Closed
CASSANDRA-19832: Build a public CI for Apache Cassandra Java Driver#1960SiyaoIsHiding wants to merge 13 commits intoapache:3.xfrom
SiyaoIsHiding wants to merge 13 commits intoapache:3.xfrom
Conversation
patch by Mick Semb Wever; reviewed by xxx for CASSANDRA-18971
SiyaoIsHiding
force-pushed
the
asf-ci-3.x
branch
from
422c36e to
1066366
Compare
SiyaoIsHiding
changed the title
ci/create-user.sh
Outdated
Comment on lines
+58
to
+60
| # we need to make SSH less strict to prevent various dtests from failing when they attempt to | ||
| # git clone a given commit/tag/etc | ||
| echo 'Host *\n UserKnownHostsFile /dev/null\n StrictHostKeyChecking no' > ${BUILD_HOME}/.ssh/config |
Jenkinsfile-asf
Outdated
Comment on lines
+65
to
+67
| def container_id = sh(script: "docker run -td -e TEST_JAVA_VERSION=${TEST_JAVA_VERSION} -e SERVER_VERSION=${SERVER_VERSION} -v \$(pwd):/home/docker/cassandra-java-driver apache.jfrog.io/cassan-docker/apache/cassandra-java-driver-testing-ubuntu2204 'sleep 2h'", returnStdout: true).trim() | ||
| sh "docker exec --user root $container_id bash -c \"sudo bash /home/docker/cassandra-java-driver/ci/create-user.sh docker \$(id -u) \$(id -g) /home/docker/cassandra-java-driver\"" | ||
| sh "docker exec --user docker $container_id './cassandra-java-driver/ci/run-tests.sh'" |
Member
There was a problem hiding this comment.
it is also possible to put the three commands into just one sh "…" (no opinions on what is best)
how are you stopping the docker container (which by default runs for two hours…?
e.g. see here https://github.com/apache/cassandra/blob/cassandra-5.0.0/.build/docker/_docker_run.sh#L140-L141
michaelsembwever
approved these changes
Sep 18, 2024
Member
michaelsembwever
left a comment
michaelsembwever
left a comment
There was a problem hiding this comment.
comment about stopping docker container.
and it's worth checking what happens to folder/file permissions when running these docker command locally.
otherwise LGTM 👍
SiyaoIsHiding
force-pushed
the
asf-ci-3.x
branch
from
fa6ffd7 to
bc096ff
Compare
michaelsembwever
approved these changes
Sep 19, 2024
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.