CASSPYTHON-17 Update DRIVER_NAME after donation to ASF#1284
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the driver-identification string sent in the Cassandra native protocol STARTUP message to reflect the project’s ASF donation and align naming with corresponding Java driver changes.
Changes:
- Update
DRIVER_NAMEfrom “DataStax Python Driver” to “Apache Cassandra Python Driver”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
A pretty simple one @bschoening but something we really need for 3.30.0. I'm going to kick off a Jenkins run just to make sure there isn't any weird regression here but I'd expect this to be pretty non-intrusive. I'm also going to do some local testing, mainly to validate the same. |
|
Local testing of this change looks pretty good. Waiting for the Jenkins run to finish to confirm there isn't any kind of regression. |
|
@dineshjoshi pointed out that we should include an explicit indication of this change in the docs since users might be looking for this string in monitoring/management apps. An update to this effect is coming. |
|
Updates to docs are now included as well. I think this is ready for you whenever you have a sec @bschoening. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| locally_supported_compressions['snappy'] = (snappy.compress, decompress) | ||
|
|
||
| DRIVER_NAME, DRIVER_VERSION = 'DataStax Python Driver', sys.modules['cassandra'].__version__ | ||
| DRIVER_NAME, DRIVER_VERSION = 'Apache Cassandra Python Driver', sys.modules['cassandra'].__version__ |
There was a problem hiding this comment.
After changing STARTUP's DRIVER_NAME, the DataStax Insights payload still hard-codes the old name (cassandra/datastax/insights/reporter.py:170 uses "DataStax Python Driver"). If Insights is expected to reflect the same driver identity change, this should be updated to match (or documented/justified if it must remain DataStax-branded).
| DRIVER_NAME, DRIVER_VERSION = 'Apache Cassandra Python Driver', sys.modules['cassandra'].__version__ | |
| DRIVER_NAME = 'Apache Cassandra Python Driver' | |
| cassandra_module = sys.modules.get('cassandra') | |
| if cassandra_module is not None and hasattr(cassandra_module, '__version__'): | |
| DRIVER_VERSION = cassandra_module.__version__ | |
| else: | |
| DRIVER_VERSION = 'unknown' |
There was a problem hiding this comment.
We'll be removing Insights support entirely in a future release (see PYTHON-1415). This hasn't been slated for a release yet but I would like to get it in sooner rather than later... Insights support is just dead weight at the moment.
|
+1 |
patch by Bret McGuire; reviewed by Bret McGuire and Brad Schoening
c87ee3b to
a726850
Compare
Update DRIVER_NAME to something consistent with corresponding change to the Java driver