Fixes updating traffic shaping options throws IllegalStateException #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankgh
commented
Aug 6, 2024
|
|
||
| sidecar: | ||
| host: 0.0.0.0 | ||
| port: 9043 |
Contributor
Author
There was a problem hiding this comment.
configuring the port to be non-zero, surfaces the issue because the logic in vert.x treats the zero port configuration differently
frankgh
force-pushed
the
CASSANDRASC-140
branch
from
e57aa0b to
77b17ad
Compare
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-140
frankgh
force-pushed
the
CASSANDRASC-140
branch
from
77b17ad to
d837b74
Compare
yifan-c
reviewed
Aug 6, 2024
Comment on lines
210
to
213
| catch (Exception exception) | ||
| { | ||
| Assertions.fail(exception); | ||
| } |
Contributor
There was a problem hiding this comment.
I guess the catch is not necessary. Is it added because IDE complains no assertion is performed?
If so, how about this?
assertThatNoException().isThrownBy(() -> {
server.start().toCompletionStage().toCompletableFuture().get(30, TimeUnit.SECONDS);
TrafficShapingOptions update = new TrafficShapingOptions()
.setOutboundGlobalBandwidth(100 * 1024 * 1024);
server.updateTrafficShapingOptions(update);
});
Contributor
Author
There was a problem hiding this comment.
Without the fix, the exception was thrown and I would fail the test. I will update the test. I was running @RepeatedTest so it was necessary to fail the test so the server was properly closed during teardown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Francisco Guerrero; Reviewed by Yifan Cai for CASSANDRASC-140