CASSSIDECAR-194: Deprecate Java 8 support for Sidecar Server#181
CASSSIDECAR-194: Deprecate Java 8 support for Sidecar Server#181frankgh merged 5 commits intoapache:trunkfrom
Conversation
Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-194
build.gradle
Outdated
| } | ||
|
|
||
| group 'org.apache.cassandra' | ||
| group 'org.apache.cassandra.sidecar' |
There was a problem hiding this comment.
to avoid having to declare the group whenever a new subproject is added. Avoiding the issues encountered in CASSSIDECAR-190
| id 'com.github.spotbugs' | ||
| } | ||
|
|
||
| group 'org.apache.cassandra.sidecar' |
There was a problem hiding this comment.
already declared in the parent
| */ | ||
|
|
||
| project.ext.JDK11_OPTIONS = ['-XX:-MaxFDLimit', | ||
| '-Djdk.attach.allowAttachSelf=true', |
There was a problem hiding this comment.
this I believe is unnecessary, but I understand this is unrelated to the PR , so I can revert if there are reservations
There was a problem hiding this comment.
I think bytebuddy and mockito need the option. Let's not change it in this patch.
| at: dtest-jars | ||
| - run: ./scripts/install-shaded-dtest-jar-local.sh | ||
| - run: ./gradlew --no-daemon -PdtestVersion=4.1.8 -Dcassandra.sidecar.versions_to_test="4.1" integrationTestHeavyWeight --stacktrace | ||
| - run: ./gradlew build --stacktrace |
There was a problem hiding this comment.
there's no integration test support for client so not needed
There was a problem hiding this comment.
A lot of java8 pipelines go away because we no longer support the Sidecar server
server/build.gradle
Outdated
|
|
||
| sourceCompatibility = 1.8 | ||
| sourceCompatibility = 11 | ||
| group 'org.apache.cassandra' |
There was a problem hiding this comment.
the server group differs from the subprojects. This doesn't change existing behavior. We declare the common group in the parent gradle (it used to be 'org.apache.cassandra') and now we explicitly declare it in the server's build.gradle file
| .dataDirs(Arrays.asList(dataDirectories)) | ||
| .storageDir(storageDir) | ||
| .dataDirs(List.of(dataDirectories)) | ||
| .cdcDir(config.getString("cdc_raw_directory")) |
There was a problem hiding this comment.
Is this cdcDir change related to dropping java8??
There was a problem hiding this comment.
this is to address a spotbugs issue that was missed in CASSSIDECAR-179 and is causing the build to fail
integration-tests/build.gradle
Outdated
|
|
||
| group 'org.apache.cassandra.sidecar' | ||
| version project.version | ||
| sourceCompatibility = 11 |
There was a problem hiding this comment.
Why not using JavaVersion.VERSION_11 like in other gradles?
There was a problem hiding this comment.
sure, I can change it
.circleci/config.yml
Outdated
| jobs: | ||
| # Runs java 8 tests on a docker image | ||
| # We only produce client artifacts for java 8 builds | ||
| unit_java8: |
There was a problem hiding this comment.
nit: rename to client_only_unit_java8?
3 participants
Patch by Francisco Guerrero; reviewed by TBD for CASSSIDECAR-194