CASSSIDECAR-400- Fixing sidecar’s ProcessLifecycleProviderIntegrationTest() failure in root mode#313
Merged
frankgh merged 2 commits intoapache:trunkfrom Feb 4, 2026
Merged
Conversation
frankgh
reviewed
Feb 4, 2026
Contributor
frankgh
left a comment
frankgh
left a comment
There was a problem hiding this comment.
I have some concerns about adding the flag by default.
| startCassandraCmd.add(cassandraBin().toString()); | ||
| startCassandraCmd.add("-p"); | ||
| startCassandraCmd.add(pidFileLocation); | ||
| startCassandraCmd.add("-R"); // Allow running as root (required for Cassandra 5.0+ when running as root) |
Contributor
There was a problem hiding this comment.
I think adding this flag to production code is dangerous. Looking at CASSANDRA-8142 the idea is to prevent this behavior by default for good reasons. I would propose that we alternatively look into having the ability to provide optional extra args that we can configure for testing purposes.
Contributor
Author
There was a problem hiding this comment.
Makes sense, I've updated the argument as a test override
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch by Shruti Sekaran; Reviewed by TBD for CASSSIDECAR-400