Closed
Conversation
ossarga
requested changes
Dec 4, 2020
Contributor
ossarga
left a comment
ossarga
left a comment
There was a problem hiding this comment.
@loganloganlogan thank you for putting the post together.
The content looks good to me. The external URLs all checkout.
I have two comments that need to be addressed before we can merge this.
| author: the Apache Cassandra Community | ||
| categories: blog | ||
| --- | ||
|  |
Contributor
There was a problem hiding this comment.
There are two things that need to change with this line.
- This image block needs to be moved under the "Our monthly roundup of key activities and knowledge to keep the community informed." line. The reason is the image will appear in the blog summary page.
- The URL is needs a leading
/. It should be:
/img/changelog_header.jpg "image_tooltip"
Currently, this line results in the blog summary page rendering as follows.
|
|
||
| [How to deploy Cassandra on Openshift and open it up to remote connections](https://sindhumurugavel.medium.com/how-to-deploy-cassandra-on-openshift-and-open-it-up-to-remote-connections-c7783861b868) - Sindhu Murugavel | ||
|
|
||
|  |
Contributor
There was a problem hiding this comment.
Similar to previous comment, the URL needs a leading /. It should be:
/img/changelog_footer.jpg "image_tooltip"
Contributor
|
Fixes made on branch cass-changelog-blog-2-update. New pull request #29 raised with the changes. This one can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited per note from @michaelsembwever. Ready for review @ossarga, thanks!