CASSANDRA-16681 #1014
Closed
CASSANDRA-16681 #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Feb 26, 2024
CNDB-8229 introduced the requirement for explicitly freezing all types. Previously, the assumption was that the tuples were frozen by definition and not explicitly wrapped in the `frozen` type. However, since the introduction of dropping non-frozen UDT columns, we need to support non-frozen tuples in dropped columns. Therefore, we should no longer assume each tuple is frozen by definition. We need to fix the type definitions when loading the old sstables. They still mention tuples without the `frozen` keyword while expecting them to be interpreted as frozen. This PR introduces a new sstable version since which the requirement is strict - in this case, the sstables mentioning non-frozen tuple types for non-dropped columns are rejected. For Converged Cassandra, due to the migration process we keep producing CB sstables while knowing how to interpret CC version. Patch by Jacek Lewandowski; reviewed by Andrés de la Peña and Jaroslaw Grabowski for CNDB-8696
jbellis
pushed a commit
to jbellis/cassandra
that referenced
this pull request
Mar 19, 2024
) * Revert "Revert "CNDB-8229: Allow dropping non-frozen UDT columns (apache#905)" (apache#996)" This reverts commit 80c2f8b. * CNDB-8696: Refactor fixing implicitly frozen tuple (apache#1014) CNDB-8229 introduced the requirement for explicitly freezing all types. Previously, the assumption was that the tuples were frozen by definition and not explicitly wrapped in the `frozen` type. However, since the introduction of dropping non-frozen UDT columns, we need to support non-frozen tuples in dropped columns. Therefore, we should no longer assume each tuple is frozen by definition. We need to fix the type definitions when loading the old sstables. They still mention tuples without the `frozen` keyword while expecting them to be interpreted as frozen. This PR introduces a new sstable version since which the requirement is strict - in this case, the sstables mentioning non-frozen tuple types for non-dropped columns are rejected. For Converged Cassandra, due to the migration process we keep producing CB sstables while knowing how to interpret CC version. Patch by Jacek Lewandowski; reviewed by Andrés de la Peña and Jaroslaw Grabowski for CNDB-8696 * CNDB-8696 bump current version of Trie format vsearch is moved to the new version (cc) as per 8696 solution description. --------- Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com> Co-authored-by: Jacek Lewandowski <lewandowski.jacek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.