CASSANDRA-12519 (4.0): dtest failure in offline_tools_test.TestOfflineTools.sstableofflinerelevel_test #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelapena
changed the title
michaeljmarshall
pushed a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Apr 3, 2024
When the code validates the footer, it complains if the remaining bytes don't match the footer lenght, but it does so before checking the footer magic. It means that when that error is triggered, you cannot really tell if the issue that you are trying to read the footer in the wrong place, or if the file genuinely has extra bytes after the footer. This modify the logic a bit to check the magic first (as long as there is enough bytes), to disambiguate both problems more easily.
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
When the code validates the footer, it complains if the remaining bytes don't match the footer lenght, but it does so before checking the footer magic. It means that when that error is triggered, you cannot really tell if the issue that you are trying to read the footer in the wrong place, or if the file genuinely has extra bytes after the footer. This modify the logic a bit to check the magic first (as long as there is enough bytes), to disambiguate both problems more easily.
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Sep 25, 2024
When the code validates the footer, it complains if the remaining bytes don't match the footer lenght, but it does so before checking the footer magic. It means that when that error is triggered, you cannot really tell if the issue that you are trying to read the footer in the wrong place, or if the file genuinely has extra bytes after the footer. This modify the logic a bit to check the magic first (as long as there is enough bytes), to disambiguate both problems more easily.
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
When the code validates the footer, it complains if the remaining bytes don't match the footer lenght, but it does so before checking the footer magic. It means that when that error is triggered, you cannot really tell if the issue that you are trying to read the footer in the wrong place, or if the file genuinely has extra bytes after the footer. This modify the logic a bit to check the magic first (as long as there is enough bytes), to disambiguate both problems more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.