CASSANDRA-16733(3.0): Add flag to disable ALTER...DROP COMPACT STORAGE statements#1061
CASSANDRA-16733(3.0): Add flag to disable ALTER...DROP COMPACT STORAGE statements#1061blerer wants to merge 4 commits intoapache:cassandra-3.0from
Conversation
There was a problem hiding this comment.
Does this one need to be volatile?
There was a problem hiding this comment.
We have a set method in {{DatabaseDescriptor}} used by the test. So potentially, the variable can be read and written by 2 different threads. I prefered to be careful.
There was a problem hiding this comment.
When we added the experimental flags for MVs and SASI indexes in CASSANDRA-14866 we also added a client warning for each of them, here and here. Shouldn't we warn users about DROP COMPACT STORAGE being experimatal too, especially given that it's allowed by default in the config?
There was a problem hiding this comment.
Of course the warning is not going to be that useful since in this case the damage is already done when the query is run. So probably it's better to just disable it by default.
There was a problem hiding this comment.
That was my reasoning. Once you have run the command and saw the warning it is effectively too late :-(
blerer
force-pushed
the
CASSANDRA-16733-3.0
branch
4 times, most recently
from
f23f808 to
651b464
Compare
blerer
force-pushed
the
CASSANDRA-16733-3.0
branch
from
651b464 to
736ce72
Compare
| public TestCase runBeforeNodeRestart(RunOnClusterAndNode runBeforeNodeRestart) | ||
| { | ||
| this.runBeforeNodeRestart = runBeforeNodeRestart; | ||
| return this; | ||
| } |
2 participants
No description provided.