modify SecondaryIndexManager#indexPartition() to retrieve only columns for which indexes are actually being built #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azotcsit
reviewed
Jul 9, 2021
Contributor
There was a problem hiding this comment.
is it necessary to disable automatic compaction twice? it has been already done on line 816.
Contributor
Author
There was a problem hiding this comment.
CC @bdeggleston
I think this was a copy/paste, so I'm wondering if it was necessary to disable twice in the original tests like testTinyPartitions() et al
Contributor
There was a problem hiding this comment.
Shouldn't this be outside of the loop?
Contributor
Author
There was a problem hiding this comment.
You're right. Good catch :)
…s for which indexes are actually being built patch by Caleb Rackliffe and Sam Tunnicliffe; reviewed by Benedict Elliott Smith for CASSANDRA-16776
maedhroz
force-pushed
the
CASSANDRA-16776
branch
from
4f6c205 to
c7e6f47
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Caleb Rackliffe for CASSANDRA-16776