CASSANDRA-16850 - Add client warnings and abort to tombstone and coordinator reads which go past a low/high watermark #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
commented
Aug 12, 2021
test/distributed/org/apache/cassandra/distributed/impl/InstanceMetrics.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
working on patch to make it so we can disable this behavior (leaving as default in 4.1 release for now) |
dcapwell
force-pushed
the
CASSANDRA-16850
branch
from
36f4e53 to
5413904
Compare
dcapwell
commented
Aug 24, 2021
| DataLimits limits, | ||
| DataRange dataRange, | ||
| IndexMetadata index) | ||
| int digestVersion, |
Contributor
Author
There was a problem hiding this comment.
only fixed the formatting here.
dcapwell
commented
Aug 24, 2021
| String msg = tombstoneAbortMessage(warnings.tombstoneAborts.get(), warnings.maxTombstoneAbortsCount.get(), command.toCQLString()); | ||
| ClientWarn.instance.warn(msg + " with " + command.loggableTokens()); | ||
| logger.warn(msg); | ||
| cfs().metric.clientTombstoneAborts.mark(); |
Contributor
Author
There was a problem hiding this comment.
should we inc if the query doesn't fail? kinda think we should inc at the throws?
…dinator reads which go past a low/high watermark
…onstanly hitting a vioalite variable
…s if it was still enabled
… as its already done in command.trackWarnings
…WarningsEnabled, so now we respect coordinator
dcapwell
force-pushed
the
CASSANDRA-16850
branch
from
e8d72c8 to
32da745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.