CASSANDRA-16911 - remove ephemeral marker file for snapshot #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
3 times, most recently
from
4bf2f26 to
a6bd336
Compare
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
from
a6bd336 to
9add645
Compare
smiklosovic
commented
Jun 17, 2022
smiklosovic
commented
Jun 17, 2022
smiklosovic
commented
Jun 17, 2022
src/java/org/apache/cassandra/service/snapshot/SnapshotManager.java
Outdated
Show resolved
Hide resolved
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
from
9add645 to
d157aa8
Compare
smiklosovic
commented
Jun 17, 2022
smiklosovic
commented
Jun 17, 2022
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
2 times, most recently
from
cb7cd8d to
64a4b8d
Compare
Contributor
pauloricardomg
left a comment
pauloricardomg
left a comment
There was a problem hiding this comment.
adding some initial comments (have not finished review yet)
src/java/org/apache/cassandra/tools/nodetool/ListSnapshots.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/service/snapshot/SnapshotManager.java
Outdated
Show resolved
Hide resolved
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
2 times, most recently
from
7052891 to
4198f85
Compare
smiklosovic
commented
Jun 22, 2022
smiklosovic
commented
Jun 22, 2022
smiklosovic
commented
Jun 22, 2022
smiklosovic
commented
Jun 22, 2022
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
from
4198f85 to
8a10586
Compare
smiklosovic
commented
Jun 25, 2022
pauloricardomg
approved these changes
Jul 1, 2022
src/java/org/apache/cassandra/service/snapshot/SnapshotManifest.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java
Outdated
Show resolved
Hide resolved
pauloricardomg
suggested changes
Jul 1, 2022
Contributor
pauloricardomg
left a comment
pauloricardomg
left a comment
There was a problem hiding this comment.
sorry approved by mistake, see comment on JIRA ticket
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
from
8a10586 to
22e0ae4
Compare
smiklosovic
commented
Jul 4, 2022
test/distributed/org/apache/cassandra/distributed/impl/Instance.java
Outdated
Show resolved
Hide resolved
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
from
22e0ae4 to
ec5531c
Compare
pauloricardomg
approved these changes
Jul 14, 2022
test/distributed/org/apache/cassandra/distributed/impl/Instance.java
Outdated
Show resolved
Hide resolved
…tManifest patch by Stefan Miklosovic; reviewed by Paulo Motta for CASSANDRA-16911
smiklosovic
force-pushed
the
CASSANDRA-16911
branch
from
ec5531c to
f543e58
Compare
michaeljmarshall
pushed a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Sep 13, 2024
* CNDB-9821: Improve performance when syncing sensors - generate fixtures outside of benchmark function - use zipf distribution for fixture data - compare alternative with and without request sensors and some variations - cache hashCodes for Sensors and Context - avoid using Pair and Optional as much as possible - use `synchronized` primitive instead of Lock - using striped lock in sensor registry Co-authored-by: Sergio Bossa <sergio.bossa@gmail.com>
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Sep 25, 2024
* CNDB-9821: Improve performance when syncing sensors - generate fixtures outside of benchmark function - use zipf distribution for fixture data - compare alternative with and without request sensors and some variations - cache hashCodes for Sensors and Context - avoid using Pair and Optional as much as possible - use `synchronized` primitive instead of Lock - using striped lock in sensor registry Co-authored-by: Sergio Bossa <sergio.bossa@gmail.com>
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
* CNDB-9821: Improve performance when syncing sensors - generate fixtures outside of benchmark function - use zipf distribution for fixture data - compare alternative with and without request sensors and some variations - cache hashCodes for Sensors and Context - avoid using Pair and Optional as much as possible - use `synchronized` primitive instead of Lock - using striped lock in sensor registry Co-authored-by: Sergio Bossa <sergio.bossa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.