CASSANDRA-16862. Fix flaky test DatabaseDescriptorRefTest. #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekaterinadimitrova2
approved these changes
Sep 20, 2021
Contributor
ekaterinadimitrova2
left a comment
ekaterinadimitrova2
left a comment
There was a problem hiding this comment.
One super nit that can be taken care of on commit.
Otherwise the patch looks good, pretty deterministic test now, I still tested everything and I can confirm:
- running both once and multiple times in Intelij succeeds
- running once and multiple times in debug mode in Intelij succeeds
- running once and multiple times with coverage in Intellij succeeds
- CircleCI multiplexer is also fine https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1116/workflows/de613a08-6ad7-4a76-b8be-d56cdb3bbcf5/jobs/6595
|
|
||
| ThreadMXBean threads = ManagementFactory.getThreadMXBean(); | ||
| int threadCount = threads.getThreadCount(); | ||
| List<Long> existingThreadids = Arrays.stream(threads.getAllThreadIds()).boxed().collect(Collectors.toList()); |
Contributor
There was a problem hiding this comment.
nit: existingThreadIds or existingThreadIDs
azotcsit
force-pushed
the
cassandra-16862_db_descriptor_test-trunk
branch
from
72c722c to
a4a3fad
Compare
Contributor
Author
|
Merged as e9645cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.