CASSANDRA-16989 trunk: Add env vars to CircleCI config generation script #1217
+135
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.circleci/readme.md
Outdated
| @@ -42,6 +42,36 @@ This script validates and applies any changes to the `config-2_1.yml` file, and | |||
| requires the [CircleCI CLI](https://circleci.com/docs/2.0/local-cli/#install) to be | |||
| installed. | |||
|
|
|||
| ## Setting envrinonment variables | |||
| Both `config-2_1.yml` and `config.yml` files contain a set of environment variables | |||
| defining things like what dtest repo and branch to use, what tests should be repeatedly | |||
Contributor
There was a problem hiding this comment.
Suggested change
| defining things like what dtest repo and branch to use, what tests should be repeatedly | |
| defining things like what dtest repo and branch to use, what tests could be repeatedly |
adelapena
force-pushed
the
16989-trunk
branch
from
c379630 to
c9b1200
Compare
k-rus
reviewed
Sep 28, 2021
.circleci/config-2_1.yml
Outdated
|
|
||
| # The values of some of these environment variables are meant to be frequently changed by developers. | ||
| # The generate.sh script contains a list of accepted environment variables that should contain some of | ||
| # these variables. Also, some variables are mentioned in the documentation, at least in |
Contributor
There was a problem hiding this comment.
Suggested change
| # these variables. Also, some variables are mentioned in the documentation, at least in | |
| # these variables. Also, some variables are mentioned in the documentation, at least in |
adelapena
force-pushed
the
16989-trunk
branch
from
11bc420 to
68b6fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.