CASSANDRA-17017 Add required -f option to nodetool verify #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedhroz
approved these changes
Sep 30, 2021
bereng
reviewed
Oct 5, 2021
Contributor
There was a problem hiding this comment.
Make this the testDefaultCall() method better to avoid duplicate code?
bereng
reviewed
Oct 5, 2021
CHANGES.txt
Outdated
Contributor
There was a problem hiding this comment.
Should add sstableverify here as well now?
smiklosovic
changed the title
jmckenzie-dev
force-pushed
the
cassandra-17017
branch
3 times, most recently
from
ec7b78e to
9a89782
Compare
Patch by Josh McKenzie; reviewed by Marcus Eriksson, Berenguer Blasi, and Caleb Rackliffe for CASSANDRA-17017 Co-authored by Josh McKenzie <jmckenzie@apache.org> Co-authored by Chris Lohfink <clohfink@apple.com>
jmckenzie-dev
force-pushed
the
cassandra-17017
branch
from
8f7d32c to
772d305
Compare
bereng
reviewed
Mar 24, 2022
|
|
||
| String[] args = cmd.getArgs(); | ||
| if (args.length != 2) | ||
| if (args.length < 2) |
Contributor
There was a problem hiding this comment.
Does this change buy you anything?
Contributor
Author
There was a problem hiding this comment.
Arguably neutral. It's vestigial from when I had force as a positional argument rather than a - flagged optional and was tinkering a bit, and I ended up leaving it because I liked it a touch more. We could go back to != 2 and ternary if you have strong feelings about it.
michaeljmarshall
pushed a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Sep 3, 2024
…oup of SAI expressions (apache#1246) NEQ is unhandled in this switch, leading to a NPE under certain query conditions where an Expression is created and no operation is set for this expression.
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Sep 25, 2024
…oup of SAI expressions (apache#1246) NEQ is unhandled in this switch, leading to a NPE under certain query conditions where an Expression is created and no operation is set for this expression.
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
…oup of SAI expressions (apache#1246) NEQ is unhandled in this switch, leading to a NPE under certain query conditions where an Expression is created and no operation is set for this expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Chris Lohfink; reviewed by Marcus Eriksson and xxxx for CASSANDRA-17017
Co-authored by Chris Lohfink clohfink@apple.com
Co-authored by Josh McKenzie jmckenzie@apache.org