Avoid unecessary array allocations and initializations when performin… #1363
Conversation
maedhroz
left a comment
maedhroz
left a comment
There was a problem hiding this comment.
LGTM, aside from some minor nits that you can take or leave
| } | ||
|
|
||
| /** | ||
| * Checks that the specified expression is <code>true</code>. If not an <code>InvalidRequestException</code> will |
There was a problem hiding this comment.
nit: It might be nice to use @link rather than code so things are navigable?
There was a problem hiding this comment.
The issue with link is that you can end up with a javadoc with a lot of link that made the generated javadoc harder to read. The general approach is to use simply use {@code } in the methods. I would prefer if we stick with the most common approach.
| * @param messageTemplate the template used to build the error message | ||
| * @param messageArgs the message arguments | ||
| * @param messageArg the message argument | ||
| * @throws InvalidRequestException if the specified expression is <code>false</code>. |
There was a problem hiding this comment.
nit: Might be easier to read quickly with a newline between the last @params and the first @throws
There was a problem hiding this comment.
I tried and felt that it was making the javadoc longer specially if I did the same when there was a @return. I checked the java classes javadoc and they do not use new line there so I decided to keep it this way.
We want to run the common tests in the subclasses of the abstract class, but not in the abstract class itself.
We want to run the common tests in the subclasses of the abstract class, but not in the abstract class itself.
3 participants
…g query checks