Conversation
…change the parameters
…around log messages, help and some variables and functions. JMX was skipped
…rameters - key_cache_save_period, row_cache_save_period, counter_cache_save_period
| if (value.symbol.equalsIgnoreCase(symbol)) | ||
| return value; | ||
| } | ||
| throw new IllegalArgumentException(String.format("Unsupported data rate unit: %s. Supported units are: %s", |
There was a problem hiding this comment.
@michaelsembwever I will change this exception also to ConfigurationException on commit, I missed it
| public int hinted_handoff_throttle_in_kb = 1024; | ||
| public int batchlog_replay_throttle_in_kb = 1024; | ||
| @Replaces(oldName = "hinted_handoff_throttle_in_kb", converter = Converters.KIBIBYTES_DATASTORAGE, deprecated = true) | ||
| public volatile DataStorageSpec hinted_handoff_throttle = new DataStorageSpec("1024KiB"); |
There was a problem hiding this comment.
If I am not missing something those should stay not volatile. I changed pre-commit
| public long row_cache_size_in_mb = 0; | ||
| public volatile int row_cache_save_period = 0; | ||
| @Replaces(oldName = "row_cache_size_in_mb", converter = Converters.MEBIBYTES_DATA_STORAGE, deprecated = true) | ||
| public volatile DataStorageSpec row_cache_size = new DataStorageSpec("0MiB"); |
There was a problem hiding this comment.
no need of volatile again
| public volatile Long index_summary_capacity_in_mb; | ||
| public volatile int index_summary_resize_interval_in_minutes = 60; | ||
| @Replaces(oldName = "index_summary_capacity_in_mb", converter = Converters.MEBIBYTES_DATA_STORAGE, deprecated = true) | ||
| public DataStorageSpec index_summary_capacity; |
There was a problem hiding this comment.
and here volatile was needed. Adding pre-commit
|
|
||
| long seconds; | ||
| //if the provided string value is just a number, then we create a Duration Spec value in seconds | ||
| if (matcher.find()) |
There was a problem hiding this comment.
wrong function, we should use, I changed it pre-commit:
```
if (matcher.matches())
{
seconds = Long.parseLong(value);
return new DurationSpec(seconds, TimeUnit.SECONDS);
}
|
@michaelsembwever This work was squashed and committed almost two weeks ago, should I just close this pull request? I am not sure what is the process as normally we use pull requests against our own forks during review. |
2 participants
No description provided.