CASSANDRA-17402: Fix ObjectSizes implementation and usages #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacek-lewandowski
force-pushed
the
CASSANDRA-17402-4.0
branch
from
7dae6fe to
86eb8e8
Compare
jacek-lewandowski
changed the title
blambov
approved these changes
Feb 25, 2022
| public static long sizeOfEmptyHeapByteBuffer() | ||
| { | ||
| return BUFFER_EMPTY_SIZE; | ||
| int arrayLen = buffer.array().length; |
adelapena
reviewed
Mar 3, 2022
| * @return Total in-memory size of the String | ||
| */ | ||
| //@TODO hard coding this to 2 isn't necessarily correct in Java 11 | ||
| // TODO hard coding this to 2 isn't necessarily correct in Java 11 |
Contributor
There was a problem hiding this comment.
Is this TODO comment still valid?
Contributor
Author
There was a problem hiding this comment.
yes, I didn't change that logic at all
Contributor
There was a problem hiding this comment.
Well, the comment is mentioning the hardcoded "2" value, I understand that meaning the 2 bytes that were passed to MemoryLayoutSpecification.sizeOfArray. However, this has changed to send Character.SIZE, which has a value of 16 bits. So we are calling sizeOfArray with the size of a char in bits, when it expects bytes. I guess we should change it to Character.BYTES.
adelapena
reviewed
Mar 7, 2022
| import org.apache.cassandra.db.rows.NativeCell; | ||
| import org.apache.cassandra.schema.ColumnMetadata; | ||
| import org.apache.cassandra.schema.TableMetadata; | ||
| import org.apache.cassandra.utils.ByteBufferUtil; |
Contributor
There was a problem hiding this comment.
Nit: unused, can be fixed on commit
michaeljmarshall
pushed a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Dec 17, 2025
### What is the issue These metrics need to be customizable. ### What does this PR fix and why was it fixed Allow custom implementations via -Dcassandra.custom_internode_outbound_metrics_provider_class
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
…he#1470) These metrics need to be customizable. Allow custom implementations via -Dcassandra.custom_internode_outbound_metrics_provider_class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.