CASSANDRA-17424 Performance and Semantic Concerns w/ Metrics for Local vs. Remote Requests in StorageProxy #1501
+2,404
−2,239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
maedhroz
commented
Mar 14, 2022
Contributor
Author
There was a problem hiding this comment.
This codepath seems to be actuated by writes on the MV's base table, so it didn't seem correct to record anything around these metrics.
maedhroz
force-pushed
the
CASSANDRA-17424
branch
from
72af6ea to
c12cb45
Compare
maedhroz
commented
Mar 14, 2022
Contributor
Author
There was a problem hiding this comment.
If this host is a replica, applyCounterMutationOnCoordinator() -> performWrite(), and there we'll mark a local request against the metrics.
Contributor
There was a problem hiding this comment.
Is it worth being explicit in this comment that the other path will ultimately update the localRequests
Contributor
|
Looks like the original test is missing anything to test the counter path. |
jonmeredith
reviewed
Mar 21, 2022
jonmeredith
approved these changes
Mar 21, 2022
maedhroz
force-pushed
the
CASSANDRA-17424
branch
from
c12cb45 to
697f371
Compare
…quests against the client request metrics patch by Caleb Rackliffe; reviewed by Jon Meredith for CASSANDRA-17424 Co-authored-by: Marcus Eriksson <marcuse@apache.org> Co-authored-by: Caleb Rackliffe <calebrackliffe@gmail.com>
maedhroz
force-pushed
the
CASSANDRA-17424
branch
from
697f371 to
df90d26
Compare
jonmeredith
approved these changes
Mar 29, 2022
Contributor
Author
|
Committed as 57ab3af |
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Feb 20, 2025
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.