CASSANDRA-17616 4.1: Add in Circle CI an option to repeat jvm dtests with vnodes #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bereng
reviewed
May 24, 2022
.circleci/config-2_1.yml
Outdated
Contributor
There was a problem hiding this comment.
Is this intentionally false?
Contributor
Author
There was a problem hiding this comment.
Yes, it is intentional. The repeated jobs try to mimic the configuration of the regular jobs, so we can reproduce failures in them. The only job for running all JVM upgrade tests (j8_jvm_upgrade_dtests) doesn't use virtual nodes, so the task for repeating individual upgrade tests doesn't use them either.
If at some point we added a j8_jvm_upgrade_dtests_vnode task, analogous to j8_jvm_dtests_vnode, we would need to add a new REPEATED_JVM_UPGRADE_DTEST_VNODES property and pass it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.