CASSANDRA-17695: Fix AbstractCell#toString for tombstoned multicell CollectionTypes #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollectionTypes Calling AbstractCell#toString on a tombstoned multicell CollectionType for the date, duration, smallint, time, and tinyint types produces a MarshalException. The root cause of the issue occurs when AbstractCell#toString in turns calls AbstractType#getString(V value, ValueAccessor<V> acccesor). The TypeSerializer performs validation of the value. However, because this value is tombstoned the size of the value is 0 which doesn't match the type value. The failed check throws a MarshalException. In this commit, we check whether the Cell is tombstoned and add the "<tombstone>" string to the output of the AbstractCell#toString method.
maedhroz
approved these changes
Jun 28, 2022
Contributor
Author
|
Merged via a9725b6 |
ekaterinadimitrova2
pushed a commit
that referenced
this pull request
Jun 9, 2025
…1705) ### What is the issue Fixes: riptano/cndb#13625 ### What does this PR fix and why was it fixed When `rerank_k` is non-positive, we will skip reranking where possible. A minor note: this change is not strictly backwards compatible because of the original implementation. However, it will fail quickly if the coordinator accepts the value but the writer does not, and since this is only a query-time parameter, I propose that we move forward and accept the net-new value that was previously disallowed.
michaeljmarshall
added a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Sep 17, 2025
### What is the issue Documents the following PRs: apache#1676, apache#1704, apache#1705
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
…pache#1705) ### What is the issue Fixes: riptano/cndb#13625 ### What does this PR fix and why was it fixed When `rerank_k` is non-positive, we will skip reranking where possible. A minor note: this change is not strictly backwards compatible because of the original implementation. However, it will fail quickly if the coordinator accepts the value but the writer does not, and since this is only a query-time parameter, I propose that we move forward and accept the net-new value that was previously disallowed.
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
### What is the issue Documents the following PRs: apache#1676, apache#1704, apache#1705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
AbstractCell#toStringon a tombstoned multi-cellCollectionTypefor thedate,duration,smallint,time, andtinyinttypes produces aMarshalException. The root cause of the issueoccurs when
AbstractCell#toStringin turns callsAbstractType#getString(V value, ValueAccessor<V> acccesor).The
TypeSerializerperforms validation of the value. However, because this value is tombstonedthe size of the value is 0 which doesn't match the type value. The failed check throws a
MarshalException.In this commit, we check whether the Cell is tombstoned and add the "" string to the
output of the
AbstractCell#toStringmethod for tombstoned cells.