17735 trunk #1737
Closed
17735 trunk #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity - Settings Virtual Table was not updated on changes after startup
adelapena
reviewed
Jul 19, 2022
Contributor
adelapena
left a comment
adelapena
left a comment
There was a problem hiding this comment.
Looks good, I have just left a couple of suggestions.
| MINUTES_DURATION(Integer.class, DurationSpec.IntMinutesBound.class, | ||
| DurationSpec.IntMinutesBound::new, | ||
| DurationSpec.IntMinutesBound::toMinutes), | ||
| o -> o == -1 ? null : new DurationSpec.IntMinutesBound(o), |
Contributor
There was a problem hiding this comment.
Maybe we should rename this converter to MINUTES_CUSTOM_DURATION and add a comment, since this is a special way of converting due to the acceptance of -1 as disabled value. That's what was done with MILLIS_CUSTOM_DURATION, although here we wouldn't have a regular/custom pair of converters.
Contributor
Author
There was a problem hiding this comment.
That and I actually got reminded that I need to update this converter unit test to include the "-1" part
ekaterinadimitrova2
force-pushed
the
17735-trunk
branch
from
d145352 to
d234872
Compare
michaeljmarshall
pushed a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Sep 17, 2025
… to `EC` so we support BM25 by default. (apache#1737) We do not need to update JVECTOR_VERSION post CNDB-14301
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
… to `EC` so we support BM25 by default. (apache#1737) We do not need to update JVECTOR_VERSION post CNDB-14301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.