Fix scrubber falling into infinite loop (trunk) #1826
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scrubber falling into infinite loop when the last partition is broken in data file and compression is enabled.
michaeljmarshall
added a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Sep 17, 2025
### What is the issue Fixes: riptano/cndb#14524 ### What does this PR fix and why was it fixed This jvector commit datastax/jvector@00a13a8 changed the `GraphSearcher` contract, and we now need to acquire a new view before each query. The expected side effect is the creation of one additional object, `ConcurrentGraphIndexView`, which in turn just has a call to `completions.clock()`, a jvector construct that ensures a consistent view of the graph (concurrent updates will not be visible). Cherry pick of datastax#1825 (cherry picked from commit 5187977)
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
### What is the issue Fixes: riptano/cndb#14524 ### What does this PR fix and why was it fixed This jvector commit datastax/jvector@00a13a8 changed the `GraphSearcher` contract, and we now need to acquire a new view before each query. The expected side effect is the creation of one additional object, `ConcurrentGraphIndexView`, which in turn just has a call to `completions.clock()`, a jvector construct that ensures a consistent view of the graph (concurrent updates will not be visible). Cherry pick of datastax#1825 (cherry picked from commit 5187977)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.