Bug fix for 'wait' time to be in nanoseconds for consistency instead of microseconds #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test behaviour fixed in CASSANDRA-18086 plus another one-line bug fix in Clock.waitUntil(). patch by Benedict Elliott Smith
michaelsembwever
force-pushed
the
mck/18086/4.1
branch
from
495250a to
ac006e5
Compare
michaelsembwever
force-pushed
the
mck/18086/4.1
branch
from
ac006e5 to
98b2a59
Compare
aweisberg
reviewed
Dec 7, 2022
| default LatencySelector write(double percentile) { return (read, write) -> write.get(percentile); } | ||
| default LatencySelector maxReadWrite(double percentile) { return (read, write) -> max(read.get(percentile), write.get(percentile)); } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Was this line break removal intentional?
aweisberg
reviewed
Dec 7, 2022
| { | ||
| ContentionStrategy strategy = parseStrategy("min=0ms,max=10ms,random=uniform").strategy; | ||
| double total = 0; | ||
| int count = 1000; |
Contributor
There was a problem hiding this comment.
Mocking sleep and time would allow measuring if it the calculations are precisely correct.
It's fine for now though.
jmckenzie-dev
approved these changes
Dec 7, 2022
Contributor
|
Committed as f0ad7eadbeb3208e08a9339881931222fdab253b |
michaeljmarshall
pushed a commit
to michaeljmarshall/cassandra
that referenced
this pull request
Dec 17, 2025
…che#2044) Adds the metrics in IndexContext and the tree view of the query's Plan to the log messages produced for slow SAI queries. There is a new system property named cassandra.sai.slow_query_log.execution_info_enabled to toggle this feature, which is enabled by default. This property can be changed dynamically at any time, without a restart. When SAI-specific information is added to the slow query logger, the log messages for slow queries can take up almost 10x the (uncompressed) disk space. In the worst of the worst cases, with all queries being permanently slower than 500ms, and at least 50 different queries, reporting every 5 seconds (the default), the slow query logger can produce around 120MB of text per day and instance. With the detailed logging, it would be 1.14GB per day.
michaelsembwever
pushed a commit
to thelastpickle/cassandra
that referenced
this pull request
Jan 7, 2026
… logger (apache#2044) Adds the metrics in IndexContext and the tree view of the query's Plan to the log messages produced for slow SAI queries. There is a new system property named cassandra.sai.slow_query_log.execution_info_enabled to toggle this feature, which is enabled by default. This property can be changed dynamically at any time, without a restart. When SAI-specific information is added to the slow query logger, the log messages for slow queries can take up almost 10x the (uncompressed) disk space. In the worst of the worst cases, with all queries being permanently slower than 500ms, and at least 50 different queries, reporting every 5 seconds (the default), the slow query logger can produce around 120MB of text per day and instance. With the detailed logging, it would be 1.14GB per day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CASSANDRA-18086