CASSANDRA-18212: Reduce memory allocations of calls to ByteBufer.duplicate() made in org.apache.cassandra.transport.CBUtil#writeValue #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NateAdere
force-pushed
the
CASSANDRA-18212-trunk
branch
from
1f26683 to
1b33ba0
Compare
smiklosovic
reviewed
Feb 1, 2023
test/unit/org/apache/cassandra/transport/DuplicateHeapBufferTest.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Feb 1, 2023
test/unit/org/apache/cassandra/transport/DuplicateHeapBufferTest.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Feb 1, 2023
test/unit/org/apache/cassandra/transport/DuplicateHeapBufferTest.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Feb 1, 2023
test/unit/org/apache/cassandra/transport/DuplicateHeapBufferTest.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Feb 1, 2023
test/unit/org/apache/cassandra/transport/DuplicateHeapBufferTest.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Feb 1, 2023
smiklosovic
reviewed
Feb 1, 2023
NateAdere
force-pushed
the
CASSANDRA-18212-trunk
branch
from
d96623a to
f2b8148
Compare
dcapwell
requested changes
Feb 3, 2023
test/unit/org/apache/cassandra/transport/DuplicateHeapBufferTest.java
Outdated
Show resolved
Hide resolved
NateAdere
force-pushed
the
CASSANDRA-18212-trunk
branch
from
3a411a6 to
8fd8e3f
Compare
dcapwell
requested changes
Feb 7, 2023
test/unit/org/apache/cassandra/transport/WriteBytesDuplicateTest.java
Outdated
Show resolved
Hide resolved
added 13 commits
February 8, 2023 12:55
NateAdere
force-pushed
the
CASSANDRA-18212-trunk
branch
from
c663ee9 to
82d8b36
Compare
dcapwell
requested changes
Feb 8, 2023
dcapwell
reviewed
Feb 22, 2023
dcapwell
reviewed
Feb 22, 2023
dcapwell
approved these changes
Feb 27, 2023
Member
|
Committed with 35f8da6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used HeapByteBuffers and ThreadLocal to allocate a ByteBuffer for every thread.
The Cassandra Jira