CASSANDRA-18242 trunk #2151
CASSANDRA-18242 trunk #2151
Conversation
patch by Jon Meredith; reviewed by David Capwell for CASSANDRA-18242
jonmeredith
changed the title
dcapwell
left a comment
dcapwell
left a comment
There was a problem hiding this comment.
only blocking comment is the lack of -XX:HeapDumpPath=build/test in the last VM param; once that is fixed I am +1
ide/idea/workspace.xml
Outdated
| -XX:MaxMetaspaceSize=1G | ||
| -XX:SoftRefLRUPolicyMSPerMB=0 | ||
| -ea | ||
| -Didea.click.expand.for.rest.of.options" /> |
There was a problem hiding this comment.
this one is new... quick google and didn't find results, what is this?
There was a problem hiding this comment.
It was an attempt to remind somebody looking at the IDEA GUI that there were options that weren't visible due to all the whitespace. As it caused confusion in review I'll just remove it.
ide/idea/workspace.xml
Outdated
| -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin | ||
| -Dlogback.configurationFile=file://$PROJECT_DIR$/conf/logback.xml | ||
| -Xmx1G | ||
| -ea |
There was a problem hiding this comment.
why did you remove -XX:HeapDumpPath=build/test?
There was a problem hiding this comment.
excellent eyes - mistake, will add back in.
jonmeredith
left a comment
jonmeredith
left a comment
There was a problem hiding this comment.
Thanks for the review
ide/idea/workspace.xml
Outdated
| -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin | ||
| -Dlogback.configurationFile=file://$PROJECT_DIR$/conf/logback.xml | ||
| -Xmx1G | ||
| -ea |
There was a problem hiding this comment.
excellent eyes - mistake, will add back in.
ide/idea/workspace.xml
Outdated
| -XX:MaxMetaspaceSize=1G | ||
| -XX:SoftRefLRUPolicyMSPerMB=0 | ||
| -ea | ||
| -Didea.click.expand.for.rest.of.options" /> |
There was a problem hiding this comment.
It was an attempt to remind somebody looking at the IDEA GUI that there were options that weren't visible due to all the whitespace. As it caused confusion in review I'll just remove it.
jonmeredith
deleted the
commit_remote_branch/CASSANDRA-18242-trunk-FFE5D00F-876C-4DFD-807E-5690125CD1B4
branch
…cution stages (apache#2151) ### What is the issue When queries execute on async stages, ExecutorLocals containing ClientWarn.State are not being propagated causing warnings to be lost. ### What does this PR fix and why was it fixed Propagate ExecutorLocals across two thread transitions: caller thread to NATIVE_TRANSPORT_REQUESTS, and NATIVE_TRANSPORT_REQUESTS to async stage.
2 participants
See https://issues.apache.org/jira/browse/CASSANDRA-18242