CASSANDRA-18294 3.0 Fix disk_failure_policy die to stop gossip, native transport and JVM #2189
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.cassandra.service; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Arrays; | ||
| import java.util.Collection; | ||
|
|
||
| import org.junit.After; | ||
| import org.junit.AfterClass; | ||
| import org.junit.Before; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
|
|
||
| import org.apache.cassandra.SchemaLoader; | ||
| import org.apache.cassandra.config.Config; | ||
| import org.apache.cassandra.config.DatabaseDescriptor; | ||
| import org.apache.cassandra.exceptions.ConfigurationException; | ||
| import org.apache.cassandra.gms.Gossiper; | ||
| import org.apache.cassandra.io.FSErrorHandler; | ||
| import org.apache.cassandra.io.FSReadError; | ||
| import org.apache.cassandra.io.sstable.CorruptSSTableException; | ||
|
Runtian marked this conversation as resolved.
Outdated
|
||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| public class DefaultFSErrorHandlerTest | ||
|
Contributor
There was a problem hiding this comment. it is better to rename the class name to DefaultFSErrorHandlerForGossipTest
Contributor
Author
There was a problem hiding this comment. This handler should also stop rpc server as well as native transport if they are running. CommitLogFailurePolicyTest.testCommitFailurePolicy_stop is also only verifying gossip.
Contributor
There was a problem hiding this comment. @Runtian what is hard about starting it? You know what just leave it as it is ... this is enough. |
||
| { | ||
| private FSErrorHandler handler = new DefaultFSErrorHandler(); | ||
| Config.DiskFailurePolicy oldDiskPolicy; | ||
| Config.DiskFailurePolicy testDiskPolicy; | ||
| private boolean gossipRunningFSError; | ||
| private boolean gossipRunningCorruptedSStableException; | ||
|
|
||
| @BeforeClass | ||
| public static void defineSchema() throws ConfigurationException | ||
| { | ||
| SchemaLoader.prepareServer(); | ||
| CassandraDaemon daemon = new CassandraDaemon(); | ||
| daemon.completeSetup(); //startup must be completed, otherwise FS error will kill JVM regardless of failure policy | ||
| StorageService.instance.registerDaemon(daemon); | ||
| StorageService.instance.initServer(); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void shutdown() | ||
| { | ||
| StorageService.instance.stopClient(); | ||
| } | ||
|
|
||
| @Before | ||
| public void setup() | ||
| { | ||
| StorageService.instance.startGossiping(); | ||
| assertTrue(Gossiper.instance.isEnabled()); | ||
| oldDiskPolicy = DatabaseDescriptor.getDiskFailurePolicy(); | ||
| } | ||
|
|
||
| public DefaultFSErrorHandlerTest(Config.DiskFailurePolicy policy, | ||
| boolean gossipRunningFSError, | ||
| boolean gossipRunningCorruptedSStableException) | ||
| { | ||
| this.testDiskPolicy = policy; | ||
| this.gossipRunningFSError = gossipRunningFSError; | ||
| this.gossipRunningCorruptedSStableException = gossipRunningCorruptedSStableException; | ||
| } | ||
|
|
||
| @Parameterized.Parameters | ||
| public static Collection<Object[]> generateData() | ||
| { | ||
|
Runtian marked this conversation as resolved.
Outdated
|
||
| return Arrays.asList(new Object[][]{ | ||
| { Config.DiskFailurePolicy.die, false, false}, | ||
| { Config.DiskFailurePolicy.ignore, true, true}, | ||
| { Config.DiskFailurePolicy.stop, false, true}, | ||
| { Config.DiskFailurePolicy.stop_paranoid, false, false}, | ||
| { Config.DiskFailurePolicy.best_effort, true, true} | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| @After | ||
| public void teardown() | ||
| { | ||
| DatabaseDescriptor.setDiskFailurePolicy(oldDiskPolicy); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFSErrors() | ||
| { | ||
| DatabaseDescriptor.setDiskFailurePolicy(testDiskPolicy); | ||
| handler.handleFSError(new FSReadError(new IOException(), "blah")); | ||
| assertEquals(gossipRunningFSError, Gossiper.instance.isEnabled()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCorruptSSTableException() | ||
| { | ||
| DatabaseDescriptor.setDiskFailurePolicy(testDiskPolicy); | ||
| handler.handleCorruptSSTable(new CorruptSSTableException(new IOException(), "blah")); | ||
| assertEquals(gossipRunningCorruptedSStableException, Gossiper.instance.isEnabled()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.