CASSANDRA-18373 Node Draining Aborts All Current SSTables Imports #2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-c
reviewed
Apr 3, 2023
yifan-c
reviewed
Apr 3, 2023
test/unit/org/apache/cassandra/service/StorageServiceDrainTest.java
Outdated
Show resolved
Hide resolved
added 3 commits
April 5, 2023 12:16
SSTables imports that have no chance of succeeding due to the node being drained fail fast. In case there are any sstables imports currently active, a draining node notifies all of them upon flushing its column family stores. Each notified sstables import aborts as soon as possible by throwing an `InterruptedException`. patch by Yuriy Semchyshyn; reviewed by Yifan Cai for CASSANDRA-18373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node draining aborts all current sstables imports
SS tables imports that will end up being ignored due to the node draining fail instead of succeeding.
Each active SS tables import periodically checks for the node status and sees whether or not it is
DRAINING.In case the node starts draining the import aborts immediately by throwing an
InterruptedException.patch by Yuriy Semchyshyn; reviewed by Yifan Cai for CASSANDRA-18373